fixes a 2-5 second freeze interval on the main menu#918
Closed
mithrand0 wants to merge 1 commit into
Closed
Conversation
this patch only add lobbies to the list, that are actually reactivedrop lobbies. This limits the amount of udp calls in the background, to rd lobbies only, reducing lobby scan calls.
Contributor
Author
|
Ben says it's Valve's fault, so let's close it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch fixes a possible 2-5 seconds freeze on the main menu.
the freeze comes from scanning a lot of lobbies, not only as:rd lobbies, but all internet lobbies. This comes forth from SteamMatchmaking, which does not apply an AppID filter by default.
This patch ensures only lobbies with gametype "reactivedrop" are added to the list. This limits the amount of udp calls further down the sequence, since only as:rd lobbies are scanned for details, instead of all lobbies.
not exactly sure why the lobbies are all scanned with udp, but at least this patch ensures only as:rd lobbies are scanned.